On Sun, Aug 14, 2022 at 09:57:03AM +0200, Stanislaw Gruszka wrote:
On Sat, Aug 13, 2022 at 04:39:51PM -0400, Sasha Levin wrote:This is a note to let you know that I've just added the patch titled wifi: iwlegacy: 4965: fix potential off-by-one overflow in il4965_rs_fill_link_cmd() to the 5.19-stable tree which can be found at: http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary The filename of the patch is: wifi-iwlegacy-4965-fix-potential-off-by-one-overflow.patch and it can be found in the queue-5.19 subdirectory. If you, or anyone else, feels it should not be added to the stable tree, please let <stable@xxxxxxxxxxxxxxx> know about it.Sorry for the late comment, but I haven't been cc-ed before and I see this patch for the first time.
[...]
I don't think this is good solution, because we skip filling various fields of link quality command and I'm not sure if such command would be properly handled by firmware. I think proper solution would be just check against LINK_QUAL_MAX_RETRY_NUM - 1 in inner loop.
This patch is already upstream, and being cherry-picked into stable. If there's anything to fix here then a new patch should be sent upstream... -- Thanks, Sasha
