This is a note to let you know that I've just added the patch titled
gpio: mpc8xxx: Fix IRQ check in mpc8xxx_probe
to the 5.16-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary
The filename of the patch is:
gpio-mpc8xxx-fix-irq-check-in-mpc8xxx_probe.patch
and it can be found in the queue-5.16 subdirectory.
If you, or anyone else, feels it should not be added to the stable tree,
please let <stable@xxxxxxxxxxxxxxx> know about it.
>From 0b39536cc699db6850c426db7f9cb45923de40c5 Mon Sep 17 00:00:00 2001
From: Miaoqian Lin <linmq006@xxxxxxxxx>
Date: Fri, 14 Jan 2022 06:48:20 +0000
Subject: gpio: mpc8xxx: Fix IRQ check in mpc8xxx_probe
From: Miaoqian Lin <linmq006@xxxxxxxxx>
commit 0b39536cc699db6850c426db7f9cb45923de40c5 upstream.
platform_get_irq() returns negative error number instead 0 on failure.
And the doc of platform_get_irq() provides a usage example:
int irq = platform_get_irq(pdev, 0);
if (irq < 0)
return irq;
Fix the check of return value to catch errors correctly.
Fixes: 76c47d1449fc ("gpio: mpc8xxx: Add ACPI support")
Signed-off-by: Miaoqian Lin <linmq006@xxxxxxxxx>
Reviewed-by: Linus Walleij <linus.walleij@xxxxxxxxxx>
Signed-off-by: Bartosz Golaszewski <brgl@xxxxxxxx>
Signed-off-by: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>
---
drivers/gpio/gpio-mpc8xxx.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
--- a/drivers/gpio/gpio-mpc8xxx.c
+++ b/drivers/gpio/gpio-mpc8xxx.c
@@ -388,8 +388,8 @@ static int mpc8xxx_probe(struct platform
}
mpc8xxx_gc->irqn = platform_get_irq(pdev, 0);
- if (!mpc8xxx_gc->irqn)
- return 0;
+ if (mpc8xxx_gc->irqn < 0)
+ return mpc8xxx_gc->irqn;
mpc8xxx_gc->irq = irq_domain_create_linear(fwnode,
MPC8XXX_GPIO_PINS,
Patches currently in stable-queue which might be from linmq006@xxxxxxxxx are
queue-5.16/drm-sun4i-dw-hdmi-fix-missing-put_device-call-in-sun.patch
queue-5.16/usb-dwc3-qcom-fix-null-vs-is_err-checking-in-dwc3_qc.patch
queue-5.16/phy-mediatek-fix-missing-check-in-mtk_mipi_tx_probe.patch
queue-5.16/gpio-mpc8xxx-fix-irq-check-in-mpc8xxx_probe.patch
queue-5.16/drivers-firmware-add-missing-platform_device_put-in-.patch
queue-5.16/parisc-pdc_stable-fix-memory-leak-in-pdcs_register_pathentries.patch
queue-5.16/gpio-idt3243x-fix-irq-check-in-idt_gpio_probe.patch
queue-5.16/scsi-ufs-ufs-mediatek-fix-error-checking-in-ufs_mtk_init_va09_pwr_ctrl.patch
queue-5.16/bluetooth-hci_qca-fix-null-vs-is_err_or_null-check-i.patch
queue-5.16/spi-spi-meson-spifc-add-missing-pm_runtime_disable-i.patch
