This is a note to let you know that I've just added the patch titled gpio: idt3243x: Fix IRQ check in idt_gpio_probe to the 5.16-stable tree which can be found at: http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary The filename of the patch is: gpio-idt3243x-fix-irq-check-in-idt_gpio_probe.patch and it can be found in the queue-5.16 subdirectory. If you, or anyone else, feels it should not be added to the stable tree, please let <stable@xxxxxxxxxxxxxxx> know about it. >From 30fee1d7462a446ade399c0819717a830cbdca69 Mon Sep 17 00:00:00 2001 From: Miaoqian Lin <linmq006@xxxxxxxxx> Date: Fri, 14 Jan 2022 06:51:24 +0000 Subject: gpio: idt3243x: Fix IRQ check in idt_gpio_probe From: Miaoqian Lin <linmq006@xxxxxxxxx> commit 30fee1d7462a446ade399c0819717a830cbdca69 upstream. platform_get_irq() returns negative error number instead 0 on failure. And the doc of platform_get_irq() provides a usage example: int irq = platform_get_irq(pdev, 0); if (irq < 0) return irq; Fix the check of return value to catch errors correctly. Fixes: 4195926aedca ("gpio: Add support for IDT 79RC3243x GPIO controller") Signed-off-by: Miaoqian Lin <linmq006@xxxxxxxxx> Reviewed-by: Linus Walleij <linus.walleij@xxxxxxxxxx> Signed-off-by: Bartosz Golaszewski <brgl@xxxxxxxx> Signed-off-by: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx> --- drivers/gpio/gpio-idt3243x.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) --- a/drivers/gpio/gpio-idt3243x.c +++ b/drivers/gpio/gpio-idt3243x.c @@ -164,8 +164,8 @@ static int idt_gpio_probe(struct platfor return PTR_ERR(ctrl->pic); parent_irq = platform_get_irq(pdev, 0); - if (!parent_irq) - return -EINVAL; + if (parent_irq < 0) + return parent_irq; girq = &ctrl->gc.irq; girq->chip = &idt_gpio_irqchip; Patches currently in stable-queue which might be from linmq006@xxxxxxxxx are queue-5.16/drm-sun4i-dw-hdmi-fix-missing-put_device-call-in-sun.patch queue-5.16/usb-dwc3-qcom-fix-null-vs-is_err-checking-in-dwc3_qc.patch queue-5.16/phy-mediatek-fix-missing-check-in-mtk_mipi_tx_probe.patch queue-5.16/gpio-mpc8xxx-fix-irq-check-in-mpc8xxx_probe.patch queue-5.16/drivers-firmware-add-missing-platform_device_put-in-.patch queue-5.16/parisc-pdc_stable-fix-memory-leak-in-pdcs_register_pathentries.patch queue-5.16/gpio-idt3243x-fix-irq-check-in-idt_gpio_probe.patch queue-5.16/scsi-ufs-ufs-mediatek-fix-error-checking-in-ufs_mtk_init_va09_pwr_ctrl.patch queue-5.16/bluetooth-hci_qca-fix-null-vs-is_err_or_null-check-i.patch queue-5.16/spi-spi-meson-spifc-add-missing-pm_runtime_disable-i.patch