On Fri, Oct 5, 2012 at 8:28 PM, Takahiro Kambe <taca@xxxxxxxxxxxxxxx> wrote: > In message <34500886.post@xxxxxxxxxxxxxxx> > on Mon, 1 Oct 2012 08:50:55 -0700 (PDT), > Tomas Kuliavas <tokul@xxxxxxxxxxxxxxxxxxxxx> wrote: >>>> Instead of copying syntax from PHP manual, code should ignore idiocy >>>> written >>>> there and use only ENT_COMPAT. ENT_HTML401 introduces backwards >>>> compatibility break and does nothing. >>> I don't understand what you meant. ENT_COMPAT or ENT_HTML401 change >>> default charset of htmlspecialchars()? >>> >> ENT_HTML401 constant is introduced only in PHP 5.4. Its value is 0. This >> constant does not change 'htmlspecialchars($string, ENT_COMPAT | >> ENT_HTML401, $encoding);' call results. Function will follow only ENT_COMPAT >> specification due to zero value set on ENT_HTML401. >> >> Your proposed patch introduces backwards compatibility break. Constant is >> not available in older PHP versions. It also follows broken PHP >> documentation synopsis, which PHP developers refused to fix. > Thanks for your clarification. Hmmmm, I'll check it later... Please try a snapshot of 1.4.23-svn on our downloads page. You may also want to look at the patch here: https://sourceforge.net/p/squirrelmail/bugs/2806/?page=5 -- Paul Lesniewski SquirrelMail Team Please support Open Source Software by donating to SquirrelMail! http://squirrelmail.org/donate_paul_lesniewski.php ------------------------------------------------------------------------------ This SF.net email is sponsored by Windows: Build for Windows Store. http://p.sf.net/sfu/windows-dev2dev ----- squirrelmail-users mailing list Posting guidelines: http://squirrelmail.org/postingguidelines List address: squirrelmail-users@xxxxxxxxxxxxxxxxxxxxx List archives: http://news.gmane.org/gmane.mail.squirrelmail.user List info (subscribe/unsubscribe/change options): https://lists.sourceforge.net/lists/listinfo/squirrelmail-users