Re: php update 5.3 -> 5.4; parseStructure() should not be called statically

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 




David C. Rankin wrote:
> 
> On 06/15/2012 06:20 PM, David C. Rankin wrote:
>> Paul,
>>
>>    I apologize if this list gets two copies of this, but I didn't see the
>> first
>> come through. Could the squirrelmail code be setting E_ALL and causing
>> this
>> problem? I don't see this issue with my other web apps. Grepping, the
>> following
>> looked suspicious. I'm not a php coder, so it could be harmless, but this
>> is
>> what I found:
>>
>> contrib/test_ldap.phps:error_reporting(E_ALL);
>>
>> include/init.php://error_reporting(E_ALL);
>> include/init.php:error_reporting($error_level);
>>
>> src/configtest.php:$php_error_reporting_original_value =
>> ini_get('error_reporting');
>> src/configtest.php:error_reporting(E_ALL);
>> src/configtest.php:echo $IND . 'error_reporting: ' .
>> $php_error_reporting_original_value . " (overridden with 2047 for this
>> page
>> only)<br />\n";
>>
>>    Could one of these be the culprit causing the E_STRICT notices I'm
>> seeing
>> despite having set ~E_STRICT in php.ini?
> 
> Paul, Tomas,
> 
>    It IS squirrelmail that is causing the errors to be displayed -- not
> the 
> php.ini setting. As a test I changed the instances of 'error_reporting'
> and 
> 'error_reporting(ALL)' in:
> 
> class/error.class.php
> contrib/test_ldap.phps
> functions/global.php
> include/init.php
> src/configtest.php
> 
>    It was a crude hack
> 
Use number instead of constant name. Not all error reporting constants are
available on older PHP version. You should not suppress E_NOTICE in
SquirrelMail. This error reporting level should be displayed to catch coding
errors.

SquirrelMail is displaying E_STRICT errors cause PHP changed error reporting
levels included in E_ALL. You can find old rants about it on php-internals.
You might call it SquirrelMail problem, but only interpreter's designers are
guilty for creating this issue.

Please don't put my name next to Paul's. I am not SquirrelMail developer.

-- 
Tomas
-- 
View this message in context: http://old.nabble.com/php-update-5.3--%3E-5.4--parseStructure%28%29-should-not-be-called-statically-tp33829192p34044248.html
Sent from the squirrelmail-users mailing list archive at Nabble.com.


------------------------------------------------------------------------------
Live Security Virtual Conference
Exclusive live event will cover all the ways today's security and 
threat landscape has changed and how IT managers can respond. Discussions 
will include endpoint security, mobile security and the latest in malware 
threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/
-----
squirrelmail-users mailing list
Posting guidelines: http://squirrelmail.org/postingguidelines
List address: squirrelmail-users@xxxxxxxxxxxxxxxxxxxxx
List archives: http://news.gmane.org/gmane.mail.squirrelmail.user
List info (subscribe/unsubscribe/change options): https://lists.sourceforge.net/lists/listinfo/squirrelmail-users


[Index of Archives]     [Video For Linux]     [Yosemite News]     [Yosemite Photos]     [gtk]     [KDE]     [Cyrus SASL]     [Gimp on Windows]     [Steve's Art]     [Webcams]

  Powered by Linux