Somebody jumped on IRC the other day, and mentioned a missing functionality from the dev branch. In stable, when hitting the "Addresses" button from compose, there are a series of "All" links above the check boxes. The idea is to toggle the check boxes. I went to duplicate this functionality onto dev in default/addrbook_search_list.tpl. Code change is relatively simple, and keeping with the use_js idea, I put the JS inside the util_addressbook.php file, but when I went to test, the code didn't work. I found 2 different "bugs". The first is the explicit hard coding of this variable, instead of basing values from the preferences, see: src/addrbook_search_html.php line 85 src/addrbook_search_html.php line 117 src/addrbook_search.php line 41 src/addrbook_search.php line 86 It appears this variable is only used in the adressbooks, and is set based on... who knows what. The problem is, when the use_js is set to on, the check boxes are replaced with links, which appear to be dependent on the compose in new window setting, but are still broken anyway. I propose dropping the crazy links option when the use_js is on. I also propose the use_js is dependent on the configuration/JS detection, and not hard coded to some value. The use_js option can then toggle the check boxes for if the "All" option should be available, as well as the code behind it. The email addresses shouldn't be clickable when JS is off, because it uses JS functions that wouldn't be available (plus don't work when compose in new window is off, and when it's on, closes compose window). Any objections? -- Jonathan Angliss <jon@xxxxxxxxxxxxxxxx> ------------------------------------------------------------------------------ Crystal Reports - New Free Runtime and 30 Day Trial Check out the new simplified licensing option that enables unlimited royalty-free distribution of the report engine for externally facing server and web deployment. http://p.sf.net/sfu/businessobjects ----- squirrelmail-users mailing list Posting guidelines: http://squirrelmail.org/postingguidelines List address: squirrelmail-users@xxxxxxxxxxxxxxxxxxxxx List archives: http://news.gmane.org/gmane.mail.squirrelmail.user List info (subscribe/unsubscribe/change options): https://lists.sourceforge.net/lists/listinfo/squirrelmail-users
