On Wed, Jun 4, 2008 at 8:25 AM, James <bjlockie@xxxxxxxxx> wrote:
> When I select an address from the addressbook and click the "Compose to
> selected" BUTTON, I get this error:
>
> "Warning: Cannot modify header information - headers already sent by
> (output started at
> /HTTP_DOC_ROOT/squirrelmail-1.4.15/functions/page_header.php:31) in
> /HTTP_DOC_ROOT/squirrelmail-1.4.15/src/addressbook.php on line 286"
>
> Can someone please see if this happens on their install.
I cannot reproduce this, but I do see it in the code. Probably a PHP
issue, but below is a patch that should fix the problem. If you don't
mind, please verify that the issue is fixed. Thanks for pointing it
out.
--- src/addressbook.php (revision 13112)
+++ src/addressbook.php (working copy)
@@ -152,8 +152,12 @@
'center', $color[4], 'colspan="2"')) . "\n";
}
-/* Create page header before addressbook_init in order to display
error messages correctly. */
-displayPageHeader($color, 'None');
+// Create page header before addressbook_init in order to
+// display error messages correctly, unless we might be
+// redirecting the browser to the compose page.
+//
+if ((empty($compose_to)) || sizeof($sel) < 1)
+ displayPageHeader($color, 'None');
/* Open addressbook, with error messages on but without LDAP (the *
* second "true"). Don't need LDAP here anyway */
@@ -277,6 +281,9 @@
if ($lookup_failed || empty($send_to)) {
$showaddrlist = true;
$defselected = $sel;
+
+ // we skipped the page header above for this
functionality, so add it here
+ displayPageHeader($color, 'None');
}
-------------------------------------------------------------------------
Check out the new SourceForge.net Marketplace.
It's the best place to buy or sell services for
just about anything Open Source.
http://sourceforge.net/services/buy/index.php
-----
squirrelmail-users mailing list
Posting guidelines: http://squirrelmail.org/postingguidelines
List address: squirrelmail-users@xxxxxxxxxxxxxxxxxxxxx
List archives: http://news.gmane.org/gmane.mail.squirrelmail.user
List info (subscribe/unsubscribe/change options): https://lists.sourceforge.net/lists/listinfo/squirrelmail-users
