Re: Attachments broken in Squirrelmail 1.4.11 ?

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 10/2/07, Pascal Maes <pascal.maes@xxxxxxxxxxxxxx> wrote:
>
> Le 2 oct. 07 à 09:03, Paul Lesniewski a écrit :
>
> > [...]
> >
> > All I can suggest is to show the HTML code for your compose screen
> > after you have added one attachment.  After you capture that HTML,
> > make sure adding another attachment or sending that message as is
> > results in the loss of the attachment that had been added when you
> > captured the HTML.

Thanks for all the testing.  You didn't show the HTML, which would
have been helpful.  It would be helpful to see the HTML of both after
the first and second attach actions.

However, some of this information was helpful, and it looks as if the
problem might be in saveAttachedFiles().  I am attaching a patch to
try.  Can you please revert all debugging changes and apply this
patch?  I can't yet guarantee that this will solve the issue since I
still cannot reproduce it.

> > Also, you can find this in src/compose.php around line 379:
> >
> > if (!empty($attachments)) {
> >     $attachments = unserialize($attachments);
> >     if (!empty($attachments) && is_array($attachments))
> >         $composeMessage->entities = $attachments;
> > }
> >
> > Change it to:
> >
> > if (!empty($attachments)) {
> >     $attachments = unserialize($attachments);
> > sm_print_r('ATTACHMENTS REINIT:', $attachments);
> >     if (!empty($attachments) && is_array($attachments))
> >         $composeMessage->entities = $attachments;
> > sm_print_r('COMPOSE MESSAGE:', $composeMessage);
> > } else {
> >     echo "<hr />ATTACHMENTS ARE EMPTY<hr />";
> >     sm_print_r($_POST);
> > }
> >
> >
>
>
> We are running apache 1.3.33 whith PHP 4.4.4
>
> The configure options for PHP are :
>
> './configure' '--prefix=/usr/local/php' '--with-tsrm-pthreads' '--
> with-ldap=/usr' '--with-apxs=/usr/apache/bin/apxs' '--with-regex=php'
> '--with-gettext=/usr/local' '--with-zlib=/usr' '--with-expat-dir=/usr/
> sfw' '--with-pear' '--with-iconv' '--enable-ftp' '--enable-sigchild'
> '--enable-tokenizer' '--enable-debug' '--enable-cli' '--enable-track-
> vars' '--enable-mbstring' '--enable-maintainer-zts' '--disable-ipv6'
> '--disable-cgi' '--disable-dba' '--disable-soap' '--disable-calendar'
> '--without-mysql' '--without-aspell' '--without-pspell' '--without-
> cpdflib' '--without-imap' '--without-sqlite' '--without-xsl' '--
> disable-pdo'
>
>
> And the modules loaded by apache are :
>
> mod_php4, mod_setenvif, mod_so, mod_unique_id, mod_usertrack,
> mod_headers, mod_expires, mod_access, mod_rewrite, mod_alias,
> mod_actions, mod_asis, mod_dir, mod_autoindex, mod_include, mod_info,
> mod_status, mod_negotiation, mod_mime, mod_mime_magic,
> mod_log_referer, mod_log_agent, mod_log_config, mod_define, mod_env,
> mod_mmap_static, http_core
>
>
>
> You will find in attachment
>
> 1) debug-compose-1.4.10a.txt : an output of the version 1.4.10a
>     I have put the following inh compose.php (line 358):
>
>     sm_print_r('COMPOSE MESSAGE:', $composeMessage);
>
>     if (!isset($mailbox) || $mailbox == '' || ($mailbox == 'None')) {
>         $mailbox = 'INBOX';
>     }
>
>     All is fine with that version
>
> 2) debug-compose-1.4.11-test1.txt : an output when all our plugins
> are active
>
> 3) debug-compose-1.4.11-test2.txt : an output when all the plugins
> are inactive
>
> 3) debug-compose-1.4.11-test3.txt : an output when I send the mail
> whitout adding the second attachement. I only choose it.
>     In that case I receive the last choosen attachment
>
> From: Pascal Maes <pascal.maes@xxxxxxxxxxxx>
> Subject: test 1.4.11 ; no plugs; two choose ; one add
> To: pascal.maes@xxxxxxxxxxxxxx
> Message-id: <58471.130.104.236.7.1191323473.squirrel@xxxxxxxxxxxxx
> dc.ucl.ac.be>
> MIME-version: 1.0
> Content-type: multipart/mixed; boundary="----=_20071002131113_55643"
> Importance: Normal
> X-Priority: 3 (Normal)
> User-Agent: SquirrelMail/1.4.11
>
> ------=_20071002131113_55643
> Content-Type: text/plain; charset="iso-8859-1"
> Content-Transfer-Encoding: 8bit
>
> test 1.4.11 ; no plugs; two choose ; one add
>
> --
> Pascal
> ------=_20071002131113_55643
> Content-Type: image/jpeg; name="78963130li.jpg"
> Content-Transfer-Encoding: base64
> Content-Disposition: attachment; filename="78963130li.jpg"
>
> 4) debug-compose-1.4.11-test4.txt : the output whith the ATTACH ARRAY
>     In that case, as the two attachments were added, I don't receive
> ny of them.
>
> From: Pascal Maes <pascal.maes@xxxxxxxxxxxx>
> Subject: test 1.4.11 + ATTACH ARRAY
> To: pascal.maes@xxxxxxxxxxxxxx
> Message-id: <58510.130.104.236.7.1191324075.squirrel@xxxxxxxxxxxxx
> dc.ucl.ac.be>
> MIME-version: 1.0
> Content-type: text/plain; charset=iso-8859-1
> Content-transfer-encoding: 8bit
> Importance: Normal
> X-Priority: 3 (Normal)
> User-Agent: SquirrelMail/1.4.11
>
> test 1.4.11 + ATTACH ARRAY
>
>
> Hope this helps
> Thanks
> --
> Pascal
>

Attachment: 1.4.11-compose.diff
Description: Binary data

-------------------------------------------------------------------------
This SF.net email is sponsored by: Microsoft
Defy all challenges. Microsoft(R) Visual Studio 2005.
http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/
--
squirrelmail-users mailing list
Posting Guidelines: http://www.squirrelmail.org/wiki/MailingListPostingGuidelines
List Address: squirrelmail-users@xxxxxxxxxxxxxxxxxxxxx
List Archives: http://news.gmane.org/thread.php?group=gmane.mail.squirrelmail.user
List Archives:  http://sourceforge.net/mailarchive/forum.php?forum_id=2995
List Info: https://lists.sourceforge.net/lists/listinfo/squirrelmail-users

[Index of Archives]     [Video For Linux]     [Yosemite News]     [Yosemite Photos]     [gtk]     [KDE]     [Cyrus SASL]     [Gimp on Windows]     [Steve's Art]     [Webcams]

  Powered by Linux