Dave Dykstra wrote:
I have now posted the patch at
http://www.squid-cache.org/bugs/show_bug.cgi?id=1996
I decided to have only an option that uses stdin, as it is simpler for
users.
- Dave
On Tue, Jun 12, 2007 at 10:52:08PM +0200, Henrik Nordstrom wrote:
tis 2007-06-12 klockan 11:24 -0500 skrev Dave Dykstra:
The man page and squid.conf still talk about a '-a port' command line
option to override the port number, even though it is gone from the
code.
Right.. cleaning up.
Because of that former option, I chose '-A fd' as the option. So
'-A 0' would work for passing in stdin. If you like, I could make it
only work via stdin, but I don't think it makes sense to support both a
general file descriptor option and a separate one for stdin-only.
Supporting both is perfectly fine.
Let
me know which way you prefer. Oh, or are you saying that squid should
check to see if stdin is a socket (with getsockopt), and if so assume it
should just use it?
No, it might be a socket in other situations. I prefer an explicit
command line option for this mode of operation.
Regards
Henrik
In future Please use the attachment feature of bugzilla to add patches.
This allows us to mark patch code as obsolete when its included into the
main squid.
Amos
