Re: [PATCH] reset qxl to vga mode

[Yuri Benditovich <ybendito@xxxxxxxxxx>]

The procedure was:

We sign the driver for Win10 only and then produce 2 driver packages: one for Win 10 (with signed one) and another one for 8.1 (we call it 'compatible') as is. It is signed by RH certificate and has all the respective limitations.

On Wed, Feb 15, 2023 at 10:44 AM Yan Vugenfirer <yvugenfi@xxxxxxxxxx> wrote:

Adding @Benditovich, Yuri 

As far as I remember, we built qxldod for Win10 only anyway.

Best regards,

Yan.

On Wed, Feb 15, 2023 at 1:54 AM Vadim Rozenfeld <vrozenfe@xxxxxxxxxx> wrote:

On Tue, Feb 14, 2023 at 10:32 PM Victor Toso <victortoso@xxxxxxxxxx> wrote:

Hi Freddy,

On Tue, Feb 14, 2023 at 11:08:21AM +0000, Frediano Ziglio wrote:
> Il giorno mar 14 feb 2023 alle ore 10:50 qi zhou <atmgnd@xxxxxxxxxxx>
> ha scritto:
> >
> > > Hi,
> > >   It looks good to me. Why it was QXL_IO_MEMSLOT_ADD I don't know. On
> > > Linux is QXL_IO_RESET too.
> >
> > May be a typo ?, here you can use sysinternal's notmyfault to test this bug.
> > 1. launch qemu use legacy bios mode. make sure qxl driver is active, then open notmyfault64.exe click on crash button. It will trigger a bsod
> > 2. without reset/patch, we cannot see bluescreen shown
> >
> > before qxl revision 5, even DodResetDevice does nothing, the qemu will do reset after detect qxl mode mismatch. see https://github.com/qemu/qemu/blob/ed71c09ffd6fbd01c2a487d47291ae57b08671ea/hw/display/qxl.c#L1315
> >
> > But qxl revison 5+ requires explicit reset
> >
> > reference:
> > not myfault: https://learn.microsoft.com/en-us/sysinternals/downloads/notmyfault
> > DXGKDDI_RESET_DEVICE : https://learn.microsoft.com/en-us/windows-hardware/drivers/ddi/dispmprt/nc-dispmprt-dxgkddi_reset_device#remarks
>
> Merged.
>
> Now the question is about release and build.
>
> Uri, Victor, should we pack a new release?

I'm not sure how to release it. We used to bundle it in
spice-guest-tools but there was a signing process too.

I see that virtio-win also bundles spice-guest-tools so, they
ship our ancient release... I see something in preinst for
amd64/w8 on qxldod [0]. Vadim, does virtio-win build/sign qxldod for
some Windows releases with fixes?

Unfortunately qxldod is not a part of the virtio-win drivers build. 

Technically, it should not be a problem to build a new version of qxldod 

driver and submit it to WHQL dashboard for attestation signing. But 

attestation signing works for Win10 drivers only.

Best,

Vadim.  

 

[0] https://fedorapeople.org/groups/virt/unattended/drivers/preinst/virtio-win/0.1.225/amd64/w8/

Cheers,
Victor