Re: [RESEND PATCH 0/5] Cleanups for the nomodeset kernel command line parameter logic

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]


Hello Thomas,

On 11/3/21 14:01, Thomas Zimmermann wrote:


>> Javier Martinez Canillas (5):
>>    drm/i915: Fix comment about modeset parameters
>>    drm: Move nomodeset kernel parameter handler to the DRM subsystem
>>    drm: Rename vgacon_text_force() function to drm_modeset_disabled()
>>    drm: Add a drm_drv_enabled() helper function
>>    drm: Use drm_drv_enabled() instead of drm_modeset_disabled()
> There's too much churn here IMHO. Please merge patches 2+3 and 4+5. And 
> I'd put patch (4+5) first, so you have the drivers out of the way. After 
> that patch (2+3) should only modify drm_drv_enabled().

Sure, I'm happy with less patches.

Thanks for your feedback.
> Best regards
> Thomas
Best regards,
Javier Martinez Canillas
Linux Engineering
Red Hat

[Index of Archives]     [Linux Virtualization]     [Linux Virtualization]     [Linux ARM Kernel]     [Linux ARM]     [Linux Omap]     [Fedora ARM]     [IETF Annouce]     [Security]     [Bugtraq]     [Linux OMAP]     [Linux MIPS]     [ECOS]     [Asterisk Internet PBX]     [Linux API]     [Monitors]