Re: FIXME advice

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]


Hi Peter,

Do you have any profiling or any evidence that suggests that this is a cause for a slow down? When I wrote that FIXME, it was a theoretical, possible problem, not a certain one. I don't know that it would be worth changing without evidence of a problem.

As far as understanding this specific code, your best bet is to spend some time with debugging on and watching messages flow. It's likely a bit more than you need, but probably would be helpful to read the protocol documentation:

Also, if you're not really comfortable with Javascript and network protocols, this may be a challenging bug to address.



On 3/30/21 10:11 PM, Browning, Peter wrote:
Good evening,

I am attempting to address the FIXME in the spice-html5 wire.js class:

    /*  FIXME - it would be faster to revise the processing code to handle
             **          multiple fragments directly.  Essentially, we
    should be
             **          able to do this without any slice() or
    combine_array_buffers() calls */

I am having difficulties understanding the code surrounding this however. I was hoping that I could get some advice or insight into the way the buffer and callback structure works. Specifically, how the process_message function processes data and how the requesting and needed functions interact. I am working to make optimizations to improve client side performance on low-end machines. Any insight or advice you can offer me would be of great help.

Best regards,

Peter Browning

Spice-devel mailing list

Spice-devel mailing list

[Index of Archives]     [Linux Virtualization]     [Linux Virtualization]     [Linux ARM Kernel]     [Linux ARM]     [Linux Omap]     [Fedora ARM]     [IETF Annouce]     [Security]     [Bugtraq]     [Linux OMAP]     [Linux MIPS]     [ECOS]     [Asterisk Internet PBX]     [Linux API]     [Monitors]