From: Victor Toso <me@xxxxxxxxxxxxxx>
Hi,
One patch that was not acked but a must to integrate most of this
patches was the "usb-redir: extend USB backend to support emulated
devices", previously v6 04/18
https://lists.freedesktop.org/archives/spice-devel/2019-September/050730.html
Frediano improved the state a bit with v6 13/18 "usb-backend: Rewrite
USB emulation support".
https://lists.freedesktop.org/archives/spice-devel/2019-September/050739.html
I don't see much of a point in having a 04/18 that introduces a few
things just to be removed on 13/18, so I had both of them merged in this
series, I hope that seems fine for you.
One thing that bothered me with v6 04/18 is the needed of usbredirparser
also for the non emulated scenario. I don't mind the design itself but
it is a lot to think and test in a single patch, so I propose to split
it.
I've also splitted a few other changes that seemed to me, could have its
own commit + rationale behind it. The diff between resulting code from
v6 and this v7 shouldn't be big.
All in all, not yet super satisfied with "usb-redir: extend USB backend
to support emulated devices" but would be fine to accept it if no ones
has better ideas for improvements or complains in the current code.
Cheers,
Victor
Frediano Ziglio (9):
usb-backend: add safe check on attach()
fixup! usb-redir: add files for SCSI and USB MSC implementation
build: Do not build usbredir dependent file is usbredir disabled
test-cd-emu: Add base test for cd-emulation
build: Use a convenience library for tests
test-cd-emu: Test attach/detach emulated device
test-cd-emu: Test detach and reattach
test-cd-emu: Make sure we can call
spice_usb_backend_channel_flush_writes
test-cd-emu: Test no libusb context support
Victor Toso (1):
usb-backend: add guard and doc to check_filter()
Yuri Benditovich (10):
usb-redir: define interfaces to support emulated devices
usb-redir: move implementation of device description to USB backend
usb-redir: do not use spice_usb_acl_helper for emulated devices
usb-backend: no emulated isoch devices
usb-backend: include usbredirparser
usb-redir: extend USB backend to support emulated devices
usb-redir: add files for SCSI and USB MSC implementation
usb-redir: add implementation of emulated CD device
usb-redir: enable redirection of emulated CD drive
usb-redir: command-line option to create emulated CD drive
src/cd-scsi-dev-params.h | 46 +
src/cd-scsi.c | 2740 ++++++++++++++++++++++++++++++++++++++
src/cd-scsi.h | 117 ++
src/cd-usb-bulk-msd.c | 543 ++++++++
src/cd-usb-bulk-msd.h | 131 ++
src/channel-usbredir.c | 31 +-
src/meson.build | 21 +-
src/scsi-constants.h | 321 +++++
src/spice-option.c | 17 +
src/usb-backend.c | 772 ++++++++++-
src/usb-backend.h | 8 +-
src/usb-device-cd.c | 784 +++++++++++
src/usb-device-cd.h | 34 +
src/usb-device-manager.c | 63 +-
src/usb-emulation.h | 88 ++
src/usbutil.c | 3 -
src/usbutil.h | 4 -
tests/cd-emu.c | 320 +++++
tests/meson.build | 12 +-
19 files changed, 5953 insertions(+), 102 deletions(-)
create mode 100644 src/cd-scsi-dev-params.h
create mode 100644 src/cd-scsi.c
create mode 100644 src/cd-scsi.h
create mode 100644 src/cd-usb-bulk-msd.c
create mode 100644 src/cd-usb-bulk-msd.h
create mode 100644 src/scsi-constants.h
create mode 100644 src/usb-device-cd.c
create mode 100644 src/usb-device-cd.h
create mode 100644 src/usb-emulation.h
create mode 100644 tests/cd-emu.c
--
2.21.0
_______________________________________________
Spice-devel mailing list
Spice-devel@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/spice-devel