Patchew URL: https://patchew.org/QEMU/20190211141509.26964-1-lhrazky@xxxxxxxxxx/ Hi, This series seems to have some coding style problems. See output below for more information: Subject: [Qemu-devel] [PATCH] spice: set device address and device display ID in QXL interface Type: series Message-id: 20190211141509.26964-1-lhrazky@xxxxxxxxxx === TEST SCRIPT BEGIN === #!/bin/bash git config --local diff.renamelimit 0 git config --local diff.renames True git config --local diff.algorithm histogram ./scripts/checkpatch.pl --mailback base.. === TEST SCRIPT END === Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384 >From https://github.com/patchew-project/qemu * [new tag] patchew/1550022537-27565-1-git-send-email-changpeng.liu@xxxxxxxxx -> patchew/1550022537-27565-1-git-send-email-changpeng.liu@xxxxxxxxx * [new tag] patchew/1550064346-17012-1-git-send-email-wexu@xxxxxxxxxx -> patchew/1550064346-17012-1-git-send-email-wexu@xxxxxxxxxx * [new tag] patchew/20190211141509.26964-1-lhrazky@xxxxxxxxxx -> patchew/20190211141509.26964-1-lhrazky@xxxxxxxxxx * [new tag] patchew/20190213130240.15492-1-armbru@xxxxxxxxxx -> patchew/20190213130240.15492-1-armbru@xxxxxxxxxx * [new tag] patchew/20190213145116.20654-1-yuri.benditovich@xxxxxxxxxx -> patchew/20190213145116.20654-1-yuri.benditovich@xxxxxxxxxx Switched to a new branch 'test' 6043704883 spice: set device address and device display ID in QXL interface === OUTPUT BEGIN === ERROR: do not use C99 // comments #87: FILE: ui/spice-core.c:876: + // equivalent to if (!pci_bus_is_root(bus)), but the function is not built ERROR: do not use C99 // comments #88: FILE: ui/spice-core.c:877: + // with PCI_CONFIG=n, avoid using an #ifdef by checking directly total: 2 errors, 0 warnings, 111 lines checked Commit 604370488342 (spice: set device address and device display ID in QXL interface) has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. === OUTPUT END === Test command exited with code: 1 The full log is available at http://patchew.org/logs/20190211141509.26964-1-lhrazky@xxxxxxxxxx/testing.checkpatch/?type=message. --- Email generated automatically by Patchew [http://patchew.org/]. Please send your feedback to patchew-devel@xxxxxxxxxx _______________________________________________ Spice-devel mailing list Spice-devel@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/spice-devel