On 2/4/19 10:45 AM, Frediano Ziglio wrote: >> >> Signed-off-by: Eduardo Lima (Etrunko) <etrunko@xxxxxxxxxx> >> --- >> meson.build | 3 +-- >> 1 file changed, 1 insertion(+), 2 deletions(-) >> >> diff --git a/meson.build b/meson.build >> index 80e4b1c..e26d817 100644 >> --- a/meson.build >> +++ b/meson.build >> @@ -164,8 +164,7 @@ endif >> # >> # global C defines >> # >> -glib_major_minor = glib_version.split('.') >> -glib_encoded_version = 'GLIB_VERSION_@0@_@1@'.format(glib_major_minor[0], >> glib_major_minor[1]) >> +glib_encoded_version = >> 'GLIB_VERSION_@0@'.format(glib_version.underscorify()) >> spice_common_global_cflags += >> ['-DGLIB_VERSION_MIN_REQUIRED=@0@'.format(glib_encoded_version), >> '-DGLIB_VERSION_MAX_ALLOWED=@0@'.format(glib_encoded_version)] >> > > As long as the glib_version is always major.minor (which is currently > the case) the code is equivalent, so Yes, this is the idea, I posted a similar patch to spice server, can you ack it as well then? -- Eduardo de Barros Lima (Etrunko) Software Engineer - RedHat etrunko@xxxxxxxxxx _______________________________________________ Spice-devel mailing list Spice-devel@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/spice-devel