Re: [PATCH spice-common 1/4] meson: Use underscorify() instead of split()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



> 
> Signed-off-by: Eduardo Lima (Etrunko) <etrunko@xxxxxxxxxx>
> ---
>  meson.build | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/meson.build b/meson.build
> index 80e4b1c..e26d817 100644
> --- a/meson.build
> +++ b/meson.build
> @@ -164,8 +164,7 @@ endif
>  #
>  # global C defines
>  #
> -glib_major_minor = glib_version.split('.')
> -glib_encoded_version = 'GLIB_VERSION_@0@_@1@'.format(glib_major_minor[0],
> glib_major_minor[1])
> +glib_encoded_version =
> 'GLIB_VERSION_@0@'.format(glib_version.underscorify())
>  spice_common_global_cflags +=
>  ['-DGLIB_VERSION_MIN_REQUIRED=@0@'.format(glib_encoded_version),
>                                 '-DGLIB_VERSION_MAX_ALLOWED=@0@'.format(glib_encoded_version)]
>  

As long as the glib_version is always major.minor (which is currently
the case) the code is equivalent, so

Acked-by: Frediano Ziglio <fziglio@xxxxxxxxxx>

Frediano
_______________________________________________
Spice-devel mailing list
Spice-devel@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/spice-devel




[Index of Archives]     [Linux Virtualization]     [Linux Virtualization]     [Linux ARM Kernel]     [Linux ARM]     [Linux Omap]     [Fedora ARM]     [IETF Annouce]     [Security]     [Bugtraq]     [Linux OMAP]     [Linux MIPS]     [ECOS]     [Asterisk Internet PBX]     [Linux API]     [Monitors]