Re: [PATCH spice-common v2] proto: Remove support for SPICE version 1

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



> On Tue, 2018-10-02 at 11:21 -0400, Frediano Ziglio wrote:
> > > On Fri, 2018-09-28 at 03:41 -0400, Frediano Ziglio wrote:
> > > > ping
> > > 
> > > Sorry, I was thinking how to handle this and eventually forgot about
> > > it. Two notes:
> > > 
> > > 1. Without really looking into the differences in the protocol, I would
> > > expect some part of the spice_codegen.py that was specific to the old
> > > protocol should be removed as well?
> > > 
> > 
> > Yes, sent some follow ups.
> 
> Yeah, noticed those after replying here.
> 
> > > 2. I think this removal of backwards compatibility should be documented
> > > somewhere, along with the versions of SPICE server/client with which it
> > > breaks compatibility. I also think we should use major versions to make
> > > compatibility breakage obvious.
> > > 
> > 
> > There's the NEWS file which is usually updated before release but it
> > won't be a bad idea to update it along the way so to not forget and
> > to avoid the people doing the release to parse all the commit log.
> > About the major we don't bump much the major... actually is still a 0.XX
> > version.
> 
> Yeah, so I suppose I'm proposing to start using the major number for
> (at least) this purpose...
> 
> Cheers,
> Lukas
> 

As it does not break API/ABI I won't surely bump so version major.
So you are proposing to bump the "visible" (from user prospective) major
version (the 0.35). As a user I would ask "what's the big leap in this
new version after 10 years?". A reply "we removed support for a protocol
we superseded 10 years ago" does not sound that exiting. On the other
hand we got Linux 4.x because 30 was a too big number so I suppose is
just question of opinions.

> > > Cheers,
> > > Lukas
> > > 

Frediano
_______________________________________________
Spice-devel mailing list
Spice-devel@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/spice-devel




[Index of Archives]     [Linux Virtualization]     [Linux Virtualization]     [Linux ARM Kernel]     [Linux ARM]     [Linux Omap]     [Fedora ARM]     [IETF Annouce]     [Security]     [Bugtraq]     [Linux OMAP]     [Linux MIPS]     [ECOS]     [Asterisk Internet PBX]     [Linux API]     [Monitors]