On Tue, Oct 02, 2018 at 10:19:01AM +0200, Victor Toso wrote: > Hi, > > On Mon, Oct 01, 2018 at 06:03:07PM +0200, Christophe Fergeau wrote: > > On Mon, Oct 01, 2018 at 05:43:26PM +0200, Victor Toso wrote: > > > From: Victor Toso <me@xxxxxxxxxxxxxx> > > > > > > Just plain ugly to have all Spice clients to warn out several times > > > due lack of gstreamer plugins for a given video-codec even though most > > > users don't really use streaming at all. > > > > Will there be a warning if they try to use streaming but the > > video codec is missing? > > This should prevent any streaming to happen as the capability for > that video-codec is disabled > > https://gitlab.freedesktop.org/spice/spice-gtk/blob/master/src/channel-display.c#L863 Ok, probably good enough as debug then. Acked-by: Christophe Fergeau <cfergeau@xxxxxxxxxx> > > > Christophe > > > > > > > > Signed-off-by: Victor Toso <victortoso@xxxxxxxxxx> > > > --- > > > src/channel-display-gst.c | 3 ++- > > > 1 file changed, 2 insertions(+), 1 deletion(-) > > > > > > diff --git a/src/channel-display-gst.c b/src/channel-display-gst.c > > > index 3b306c1..73bcbe9 100644 > > > --- a/src/channel-display-gst.c > > > +++ b/src/channel-display-gst.c > > > @@ -747,7 +747,8 @@ gboolean gstvideo_has_codec(int codec_type) > > > GST_ELEMENT_FACTORY_TYPE_MEDIA_IMAGE; > > > all_decoders = gst_element_factory_list_get_elements(type, GST_RANK_NONE); > > > if (all_decoders == NULL) { > > > - spice_warning("No video decoders from GStreamer were found"); > > > + spice_debug("No video decoders from GStreamer for %s were found", > > > + gst_opts[codec_type].name); > > > return FALSE; > > > } > > > > > > -- > > > 2.17.1 > > > > > > _______________________________________________ > > > Spice-devel mailing list > > > Spice-devel@xxxxxxxxxxxxxxxxxxxxx > > > https://lists.freedesktop.org/mailman/listinfo/spice-devel > >
Attachment:
signature.asc
Description: PGP signature
_______________________________________________ Spice-devel mailing list Spice-devel@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/spice-devel