Re: [cacard 1/5] hex_dump: Remove unused arguments

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, Aug 22, 2018 at 11:46:59AM +0200, Christophe Fergeau wrote:
> Hey,
> 
> On Tue, Aug 21, 2018 at 05:30:50PM +0200, Jakub Jelen wrote:
> > On Tue, 2018-08-21 at 17:03 +0200, Christophe Fergeau wrote:
> > > hex_dump() callers can theoretically provide the destination buffer
> > > for the hexdump'ed string, but nothing in libcacard uses that
> > > feature.
> > > This commit removes it.
> > 
> > The initial idea was to create some g_debug_hex function that could use
> > that with dynamic allocation, but that never happened. It does not make
> > sense to ship dead code.
> 
> On the dynamic allocation front, I experimented with
> https://gitlab.com/teuf/libcacard/commit/472ad2e6df31472120e0d22d
> together with a DUMP_BUFFER macro wrapping the allocation/freeing of the
> buffer, but still unsure this is the right way forward... ;)

Forgot to mention, Frediano pointed out the current approach with a
static buffer would have issues if called from multiple threads.

Christophe

Attachment: signature.asc
Description: PGP signature

_______________________________________________
Spice-devel mailing list
Spice-devel@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/spice-devel

[Index of Archives]     [Linux Virtualization]     [Linux Virtualization]     [Linux ARM Kernel]     [Linux ARM]     [Linux Omap]     [Fedora ARM]     [IETF Annouce]     [Security]     [Bugtraq]     [Linux OMAP]     [Linux MIPS]     [ECOS]     [Asterisk Internet PBX]     [Linux API]     [Monitors]