Hey, On Tue, Aug 21, 2018 at 05:30:50PM +0200, Jakub Jelen wrote: > On Tue, 2018-08-21 at 17:03 +0200, Christophe Fergeau wrote: > > hex_dump() callers can theoretically provide the destination buffer > > for the hexdump'ed string, but nothing in libcacard uses that > > feature. > > This commit removes it. > > The initial idea was to create some g_debug_hex function that could use > that with dynamic allocation, but that never happened. It does not make > sense to ship dead code. On the dynamic allocation front, I experimented with https://gitlab.com/teuf/libcacard/commit/472ad2e6df31472120e0d22d together with a DUMP_BUFFER macro wrapping the allocation/freeing of the buffer, but still unsure this is the right way forward... ;) Christophe
Attachment:
signature.asc
Description: PGP signature
_______________________________________________ Spice-devel mailing list Spice-devel@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/spice-devel