On Wed, 2018-08-01 at 00:19 +0200, Marc-André Lureau wrote: > Hi > > On Tue, Jul 31, 2018 at 4:50 PM, Jakub Jelen <jjelen@xxxxxxxxxx> > wrote: > > * This is useful for CI or manual running of the tests without a > > need > > of a physical CAC card. > > * The script goes through the whole setting of environment, soft > > token, > > generating testing keys, certificates and running the test > > suite. > > Annoyingly, this isn't done as part of make check, but should be run > first. This can be fixed later. The make check runs the tests against whatever is configured including real card. I did not want to wire the softhsm into make check directly since it is not the only use case (but only suitable for CI). > > [...] > > +# Drop the requirement of HW slot in the libcacard: > > +sed -e 's/ || !PK11_IsHW(slot)//g' -i.backup src/vcard_emul_nss.c > > This is quite a hack too! you could simply introduce an option or an > environement variable for testing... If you don't address it now, > please add a TODO. Yes, this was one of the concerns we had. This is supposed to be really testing only configuration option, because for real usage, we are interested only in HW cards. Using configuration option seems to me as an overkill, especially if we would like to test real cards and the configuration string is wired in the tests. Using environment variable is probably sensible solution so I will update the patch. Thanks, -- Jakub Jelen Software Engineer Security Technologies Red Hat, Inc. _______________________________________________ Spice-devel mailing list Spice-devel@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/spice-devel