Re: [PATCH libcacard 08/45] hex_dump: Helper function to allow inspection of internal buffers

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, 2018-07-31 at 23:58 +0200, Marc-André Lureau wrote:
> Hi
> 
> On Tue, Jul 31, 2018 at 11:53 PM, Marc-André Lureau
> <marcandre.lureau@xxxxxxxxx> wrote:
> > Hi
> > 
> > On Tue, Jul 31, 2018 at 4:50 PM, Jakub Jelen <jjelen@xxxxxxxxxx>
> > wrote:
> > > Signed-off-by: Jakub Jelen <jjelen@xxxxxxxxxx>
> > > Reviewed-by: Robert Relyea <rrelyea@xxxxxxxxxx>
> > 
> > This isn't used in your tree, let's not add dead code.
> 
> My bad, the function is called hex_dump(), that confused me (usually
> it's hexdump, like the command)
> 
> > 
> > fwiw, there are more elegant implementations we could adopt if
> > needed,
> > like  _g_dbus_hexdump() in glib.
> 
> let's use your implementation for now

I was searching for a function from glib under debug/logging functions,
but not under the dbus.

Jakub

_______________________________________________
Spice-devel mailing list
Spice-devel@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/spice-devel




[Index of Archives]     [Linux Virtualization]     [Linux Virtualization]     [Linux ARM Kernel]     [Linux ARM]     [Linux Omap]     [Fedora ARM]     [IETF Annouce]     [Security]     [Bugtraq]     [Linux OMAP]     [Linux MIPS]     [ECOS]     [Asterisk Internet PBX]     [Linux API]     [Monitors]