On Tue, 2018-02-20 at 11:34 +0100, Victor Toso wrote: > On Tue, Feb 20, 2018 at 11:21:47AM +0100, Lukáš Hrázký wrote: > > On Tue, 2018-02-20 at 11:02 +0100, Victor Toso wrote: > > > IMHO, tests are a must for development and should be optional > > > on tarballs from releases. That means that packagers can > > > enable it and deal with whatever we do for testing if they > > > want to. > > > > Thing is, there shouldn't be much (if really anything) you have > > to deal with for unittests... It's certainly the case atm. > > For us. If we request Catch and Catch is not there for DISTROX, > they have to disable it in order to have build working or install > Catch. IMHO, for released tarballs one should enable testing if > they want to, not disable if they must. Let's agree we disagree on this one :) > > > More importantly is that we have tests running successfully on > > > some Linux distros (IMO, Fedora and Debian should be enough) and > > > that's why gitlab-ci is there for. > > > > You have different versions of dependencies on different > > distros, so Fedora and Debian are not entirely enough. And if > > you do it properly, having the benefit of the tests being run > > on each distro it's packaged for doesn't cost much... (I'd say > > the benefit is more for the distros, we are basically helping > > them by forcing the tests on them :D) > > I say Fedora and Debian due .rpm and .deb which several distros > might follow so we benefit on testing those two... but if we > care, then we should enable some unit test in the CI. Well, that's what CI is for, so we definitely should... > > > Also IMO, if we change the behavior of unit tests here, we > > > should do for all Spice components in order to be consistent. > > > > You mean the fact that we run them during packaging? > > That tests are not enabled by default. If we enable it by default > here I would expect to do the same for other Spice components. Ok, but I'm somewhat confused here. Enabling the tests is during packaging - you run `make check`. Which means we are talking about... Fedora packaging? Or am I getting something wrong? Cheers, Lukas _______________________________________________ Spice-devel mailing list Spice-devel@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/spice-devel