> On 15 Feb 2018, at 13:41, Christophe Fergeau <cfergeau@xxxxxxxxxx> wrote: > > On Thu, Feb 15, 2018 at 11:55:44AM +0100, Christophe de Dinechin wrote: >> Now, Christophe’s arguments are that >> >> 1) we should not write guidelines that are inconsistent with existing code. >> 2) this is in the server codebase, so we should server rules >> >> Problem is with 2, really. >> >> We started updating the guidelines because we wanted to talk about C++ >> style in the streaming agent, not the server. >> I updated the server guidelines, because that’s historically where the >> style guide has been, and the only place where SPICE has one. >> >> For now, I’d vote for stating that the server guidelines apply to all >> of the SPICE code. If we decide that means we should move them >> elsewhere, that’s fine with me. >> >> If that idea is accepted, then Christophe (2) no longer hold, and we >> can explicitly state that we accept both // and /* for all comments, >> including that one. > > My patch was changing the example from using // to using /*, That part I’m OK with. > and was > adding a note explicitly saying // was acceptable too. That may have been your intent, but the way you wrote it was: "C++ headers would use C++ comments." This suggests that you can’t use // in C headers. Is that something we really want to enforce? Again, I’d much prefer that we write somewhere that // or /* comments are both OK (not specifically for headers guards) > > Christophe > _______________________________________________ > Spice-devel mailing list > Spice-devel@xxxxxxxxxxxxxxxxxxxxx > https://lists.freedesktop.org/mailman/listinfo/spice-devel _______________________________________________ Spice-devel mailing list Spice-devel@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/spice-devel