Re: [PATCH spice-streaming-agent 1/3] Don't tag the plugin interface as 1.0 just yet

[Frediano Ziglio <fziglio@xxxxxxxxxx>]

On 14 Nov 2017, at 16:22, Frediano Ziglio <fziglio@xxxxxxxxxx> wrote:

From: Christophe de Dinechin <dinechin@xxxxxxxxxx>

Signed-off-by: Christophe de Dinechin <dinechin@xxxxxxxxxx>
---
include/spice-streaming-agent/plugin.hpp | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/include/spice-streaming-agent/plugin.hpp
b/include/spice-streaming-agent/plugin.hpp
index 727cb3b..607fabf 100644
--- a/include/spice-streaming-agent/plugin.hpp
+++ b/include/spice-streaming-agent/plugin.hpp
@@ -26,7 +26,7 @@ class FrameCapture;
 * where MM is major and mm is the minor, can be easily expanded
 * using more bits in the future
 */
-enum Constants : unsigned { PluginVersion = 0x100u };
+enum Constants : unsigned { PluginVersion = 0x001u };

enum Ranks : unsigned {
    /// this plugin should not be used

Nack... ABI not compatible

Precisely. We should not have started at 1.0. I think it’s still time to fix it.

Christophe

Going backward? Would not be easier to get to 1.1 instead?

Also 0x1 does not fit with the comment above.

Frediano

_______________________________________________
Spice-devel mailing list
Spice-devel@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/spice-devel