On Tue, Sep 12, 2017 at 06:55:41AM -0400, Frediano Ziglio wrote: > > > > On Tue, Sep 12, 2017 at 06:42:16AM -0400, Frediano Ziglio wrote: > > > In this case you are introducing a regression, current code is > > > designed to support this already. I cannot surely say that this > > > patch is an improvement. > > > > By that reasoning, any patch which makes some functions static or remove > > some unused functions is a regression. > > > > Christophe > > > > Depends on the design. In this case is designed to be reused. If you want 1) that the same ENABLE_EXTRA_CHECKS symbol name is reused in my v1 2) that it's globally #defined to 0/1 then yes, we are back to square 1, we should never use #ifndef/#ifdef with it, which my suggestion and then patch was trying to address. Christophe _______________________________________________ Spice-devel mailing list Spice-devel@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/spice-devel