> On 4 Aug 2017, at 12:48, Victor Toso <victortoso@xxxxxxxxxx> wrote: > > Hi, > > On Fri, Aug 04, 2017 at 12:42:39PM +0200, Christophe de Dinechin wrote: >> During the discussion on PRs and stuff, several people pointed to >> patchwork. >> >> Does anyone know why this tool does not acknowledge acks? For example >> https://patchwork.freedesktop.org/series/27298/ has a "Acked-by: >> Christophe de Dinechin <dinechin@xxxxxxxxxx>” in the fifth comment, >> and has been merged as 4cdd6e07d3f7ec07dccfa11c12099cb45ac60d3d. Yet >> it’s still marked as “New” by patchwork. > > It parses the acked-by and does +1 per-patch > https://patchwork.freedesktop.org/project/Spice/patches/ It does not seem too smart about it though. I wrote “can’t ack right now”, and it apparently counted that as a second “ack” :-D > > That`s the only automated feature that it does, afaik. > >> There are a few series marked as “Done”: >> https://patchwork.freedesktop.org/project/Spice/series/?ordering=-last_updated. >> For example, this one https://patchwork.freedesktop.org/series/25980/ >> was marked as “Done”. It’s recent (June 19). Christophe, did you >> explicitly mark it as “Done”, or is some fuzzy parser in patchwork >> smart enough to parse your "I've now pushed this upstream” comment? >> >> Christophe > > It does not check if given patch was pushed, no. :( If so, that’s a lot less useful than PRs. Christophe _______________________________________________ Spice-devel mailing list Spice-devel@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/spice-devel