> > On Tue, Jul 04, 2017 at 01:02:39AM -0400, Frediano Ziglio wrote: > > > > > > Constants, especially when defined using #define usually use upper-case > > > naming. > > > > However this is not coherent with wmimax and wmiext. > > Maybe changing all? > > That would mean changing the various arrays of constants too > (tabrand_chaos, bppmask, ..) > Not really. I was suggesting only to replace the integrals with #defines. > > > Another way to define compile time constant in C is using > > enum but then you'll have a warning with switches. > > Are you using -O0 ? > > Ah indeed, this is only triggered with -O0. > Yes, should have compiled the code with -O0 before sending the patch. > Christophe > Frediano _______________________________________________ Spice-devel mailing list Spice-devel@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/spice-devel