Re: [spice-common 2/2] quic: Use upper-case for 'evol' constant name

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, Jul 04, 2017 at 01:02:39AM -0400, Frediano Ziglio wrote:
> > 
> > Constants, especially when defined using #define usually use upper-case
> > naming.
> 
> However this is not coherent with wmimax and wmiext.
> Maybe changing all?

That would mean changing the various arrays of constants too
(tabrand_chaos, bppmask, ..)


> Another way to define compile time constant in C is using
> enum but then you'll have a warning with switches.
> Are you using -O0 ?

Ah indeed, this is only triggered with -O0.

Christophe

Attachment: signature.asc
Description: PGP signature

_______________________________________________
Spice-devel mailing list
Spice-devel@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/spice-devel

[Index of Archives]     [Linux ARM Kernel]     [Linux ARM]     [Linux Omap]     [Fedora ARM]     [IETF Annouce]     [Security]     [Bugtraq]     [Linux]     [Linux OMAP]     [Linux MIPS]     [ECOS]     [Asterisk Internet PBX]     [Linux API]     [Monitors]