On Wed, Jun 14, 2017 at 04:24:17PM +0000, Marc-André Lureau wrote: > On Thu, Jun 8, 2017 at 12:59 PM Christophe Fergeau <cfergeau@xxxxxxxxxx> > wrote: > > As I said, we are not going to agree there :) "If it's used > > consistently, it does not cause confusion", does not mean that's a good > > thing :) This just makes things harder to read for someone not knowing > > the convention, and for no great reason (saving at most a few seconds of > > typing?) > > > > Ok you don't like that single letter variable, but as maintainer I prefer > consistency, even though I don't have written rules, I am not strict > either. If you feel strongly about it, I can drop the patch. I suggest you > send a patch to change it if you think it will improve readability anyway. "send a patch to change it", I'm not sure what you mean by "it"? Regardless of that, given the back and forth, I'd say you have a strong preference for this, so just keep that patch in the series :) Christophe
Attachment:
signature.asc
Description: PGP signature
_______________________________________________ Spice-devel mailing list Spice-devel@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/spice-devel