On Wed, Jan 11, 2017 at 05:58:55AM -0500, Frediano Ziglio wrote:
> >
> > It's already defined before in the same source file.
> >
> > Based on a patch from Frediano Ziglio <fziglio@xxxxxxxxxx>
> >
> > Signed-off-by: Christophe Fergeau <cfergeau@xxxxxxxxxx>
> > ---
> > server/sound.c | 1 -
> > 1 file changed, 1 deletion(-)
> >
> > diff --git a/server/sound.c b/server/sound.c
> > index 1f6c243..d24a0d9 100644
> > --- a/server/sound.c
> > +++ b/server/sound.c
> > @@ -123,7 +123,6 @@ struct SndChannelClient {
> > snd_channel_cleanup_channel_proc cleanup;
> > };
> >
> > -typedef struct AudioFrame AudioFrame;
> > struct AudioFrame {
> > uint32_t time;
> > uint32_t samples[SND_CODEC_MAX_FRAME_SIZE];
>
> Can I ack my hunk or should I consider your signed-off like
> an ack? I usually prefer a sign A + sign B + ack A
Dunno :) I'm personally fine with considering everything up to
"sound: Add sanity checks in snd_{playback,record}_send" (included) as
Acked-by: Christophe Fergeau <cfergeau@xxxxxxxxxx>
though I would not ack a patch I'm also marked as the git author, so
having your ack on top makes sense I guess.
Christophe
Attachment:
signature.asc
Description: PGP signature
_______________________________________________ Spice-devel mailing list Spice-devel@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/spice-devel