> > man 2 dup2 specifies: > The close-on-exec flag (FD_CLOEXEC; see fcntl(2)) for > the duplicate descriptor is off. > > Since the purpose of the fcntl call is to turn off FD_CLOEXEC > flag, and it's already done, just remove this call. > > Suggested-by: Frediano Ziglio <fziglio@xxxxxxxxxx> > Signed-off-by: Uri Lublin <uril@xxxxxxxxxx> > --- > server/red-record-qxl.c | 4 ---- > 1 file changed, 4 deletions(-) > > diff --git a/server/red-record-qxl.c b/server/red-record-qxl.c > index 184d6b9..ee22236 100644 > --- a/server/red-record-qxl.c > +++ b/server/red-record-qxl.c > @@ -21,7 +21,6 @@ > > #include <stdbool.h> > #include <inttypes.h> > -#include <fcntl.h> > #include <glib.h> > #include "red-common.h" > #include "memslot.h" > @@ -851,9 +850,6 @@ static void child_output_setup(gpointer user_data) > continue; > } > close(fd); > - > - // make sure file is not closed calling exec() > - fcntl(STDOUT_FILENO, F_SETFD, 0); > } > > RedRecord *red_record_new(const char *filename) Acked-by: Frediano Ziglio <fziglio@xxxxxxxxxx> Frediano _______________________________________________ Spice-devel mailing list Spice-devel@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/spice-devel