> > Spice coding style suggests to use curly braces > for while blocks. > > Some prefer the block to not be empty so continue > is untouched. > > Signed-off-by: Uri Lublin <uril@xxxxxxxxxx> > --- > server/red-record-qxl.c | 6 ++++-- > 1 file changed, 4 insertions(+), 2 deletions(-) > > diff --git a/server/red-record-qxl.c b/server/red-record-qxl.c > index 14a68a7..184d6b9 100644 > --- a/server/red-record-qxl.c > +++ b/server/red-record-qxl.c > @@ -847,8 +847,9 @@ static void child_output_setup(gpointer user_data) > { > int fd = GPOINTER_TO_INT(user_data); > > - while (dup2(fd, STDOUT_FILENO) < 0 && errno == EINTR) > + while (dup2(fd, STDOUT_FILENO) < 0 && errno == EINTR) { > continue; > + } > close(fd); > > // make sure file is not closed calling exec() > @@ -890,8 +891,9 @@ RedRecord *red_record_new(const char *filename) > fclose(f); > spice_error("failed to setup filter for replay"); > } > - while (dup2(fd_in, fileno(f)) < 0 && errno == EINTR) > + while (dup2(fd_in, fileno(f)) < 0 && errno == EINTR) { > continue; > + } > close(fd_in); > } > Acked-by: Frediano Ziglio <fziglio@xxxxxxxxxx> Frediano _______________________________________________ Spice-devel mailing list Spice-devel@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/spice-devel