Re: [PATCH v4 03/17] sound: Rename {Record, Playback}Channel to *ChannelClient

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, Dec 01, 2016 at 11:24:25AM +0000, Frediano Ziglio wrote:
> Make easier to understand that they refer to client and not
> all channel.
> 
> Specifically:
> - RecordChannel -> RecordChannelClient
> - PlaybackChannel -> PlaybackChannelClient
> - playback_channel -> playback_client
> - record_channel -> record_client
> 
> Signed-off-by: Frediano Ziglio <fziglio@xxxxxxxxxx>
> ---
>  server/sound.c | 368 +++++++++++++++++++++++++-------------------------
>  1 file changed, 184 insertions(+), 184 deletions(-)

> @@ -1194,12 +1194,12 @@ static void snd_set_playback_peer(RedChannel *channel, RedClient *client, RedsSt
>                                    int num_caps, uint32_t *caps)
>  {
>      SndWorker *worker = g_object_get_data(G_OBJECT(channel), "sound-worker");
> -    PlaybackChannel *playback_channel;
> +    PlaybackChannelClient *playback_client;
>  
>      snd_disconnect_channel(worker->connection);
>  
> -    if (!(playback_channel = (PlaybackChannel *)__new_channel(worker,
> -                                                              sizeof(*playback_channel),
> +    if (!(playback_client = (PlaybackChannelClient *)__new_channel(worker,
> +                                                              sizeof(*playback_client),
>                                                                SPICE_CHANNEL_PLAYBACK,
>                                                                client,
>                                                                stream,

Alignment

> @@ -1440,12 +1440,12 @@ static void snd_set_record_peer(RedChannel *channel, RedClient *client, RedsStre
>                                  int num_caps, uint32_t *caps)
>  {
>      SndWorker *worker = g_object_get_data(G_OBJECT(channel), "sound-worker");
> -    RecordChannel *record_channel;
> +    RecordChannelClient *record_client;
>  
>      snd_disconnect_channel(worker->connection);
>  
> -    if (!(record_channel = (RecordChannel *)__new_channel(worker,
> -                                                          sizeof(*record_channel),
> +    if (!(record_client = (RecordChannelClient *)__new_channel(worker,
> +                                                          sizeof(*record_client),
>                                                            SPICE_CHANNEL_RECORD,
>                                                            client,
>                                                            stream,

Alignment too

Acked-by: Christophe Fergeau <cfergeau@xxxxxxxxxx>

Attachment: signature.asc
Description: PGP signature

_______________________________________________
Spice-devel mailing list
Spice-devel@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/spice-devel

[Index of Archives]     [Linux ARM Kernel]     [Linux ARM]     [Linux Omap]     [Fedora ARM]     [IETF Annouce]     [Security]     [Bugtraq]     [Linux]     [Linux OMAP]     [Linux MIPS]     [ECOS]     [Asterisk Internet PBX]     [Linux API]     [Monitors]