On Thu, Dec 01, 2016 at 11:24:24AM +0000, Frediano Ziglio wrote:
> SndWorker has been historically based on RedChannel, initial git commit
> has:
> struct SndWorker {
> Channel base;
> ...
> };
>
> SndChannel, contrary to what its name may imply is more focused on
> marshalling/sending of sound data, which is the responsibility of
> RedChannelClient for the other SPICE channels.
>
> This commit and following ones make the naming of these 2 types more
> consistent with how the rest of the code is structured.
>
> Signed-off-by: Frediano Ziglio <fziglio@xxxxxxxxxx>
> ---
> server/sound.c | 522 +++++++++++++++++++++++++-------------------------
> 1 file changed, 261 insertions(+), 261 deletions(-)
Basing most of my review on the count of line changed ;)
> -static SndChannel *__new_channel(SndWorker *worker, int size, uint32_t channel_id,
> - RedClient *client,
> +static SndChannelClient *__new_channel(SndWorker *worker, int size, uint32_t channel_id,
> + RedClient *red_client,
> RedsStream *stream,
> int migrate,
> snd_channel_send_messages_proc send_messages,
Alignment got broken here
Acked-by: Christophe Fergeau <cfergeau@xxxxxxxxxx>
Attachment:
signature.asc
Description: PGP signature
_______________________________________________ Spice-devel mailing list Spice-devel@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/spice-devel