From: Victor Toso <me@xxxxxxxxxxxxxx>
As spice_usbredir_channel_up() can be called when channel-usbredir is
not yet initialized, priv->host can be NULL leading to a crash in
usbredir.
See previous patch that does initialize SpiceUsbDeviceManager on
SpiceSession init and also the comment in 5b252b0f499601bcf387c02a4
which fix similar behavior.
We should simply log a critical message instead of crashing the
application.
Signed-off-by: Victor Toso <victortoso@xxxxxxxxxx>
---
src/channel-usbredir.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/src/channel-usbredir.c b/src/channel-usbredir.c
index 4837d68..392a35e 100644
--- a/src/channel-usbredir.c
+++ b/src/channel-usbredir.c
@@ -817,6 +817,8 @@ static void spice_usbredir_channel_up(SpiceChannel *c)
SpiceUsbredirChannel *channel = SPICE_USBREDIR_CHANNEL(c);
SpiceUsbredirChannelPrivate *priv = channel->priv;
+ g_return_if_fail(priv->host != NULL);
+
/* Flush any pending writes */
usbredirhost_write_guest_data(priv->host);
}
--
2.9.3
_______________________________________________
Spice-devel mailing list
Spice-devel@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/spice-devel