Re: [spice-gtk v2 2/2] channel-usbredir: prevent crash when calling without host

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi,

On Thu, Dec 01, 2016 at 01:33:56PM +0100, Christophe Fergeau wrote:
> On Wed, Nov 30, 2016 at 06:57:12PM +0100, Victor Toso wrote:
> > Hi,
> > 
> > On Wed, Nov 30, 2016 at 06:45:45PM +0100, Pavel Grunt wrote:
> > > imho this should be in usbredir
> > >
> > > It is not nice when library crashes your program
> > 
> > I don't disagree. Libraries should use guards accordingly.
> > 
> > But it doesn't make this correct. We should have initialized
> > usbredirhost before calling this API, making this a spice-gtk mistake.
> > 
> > Either way is fine to me... maybe both :)
> 
> I guess an usbredir patch adding such guards to public entry points
> would be accepted.
>
> Christophe

Okay, I'll look into the public APIs in usbredir and set some guards
there too.

  Cheers


Attachment: signature.asc
Description: PGP signature

_______________________________________________
Spice-devel mailing list
Spice-devel@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/spice-devel

[Index of Archives]     [Linux ARM Kernel]     [Linux ARM]     [Linux Omap]     [Fedora ARM]     [IETF Annouce]     [Security]     [Bugtraq]     [Linux]     [Linux OMAP]     [Linux MIPS]     [ECOS]     [Asterisk Internet PBX]     [Linux API]     [Monitors]