On Wed, 23 Nov 2016, Christophe Fergeau wrote: > On Wed, Nov 23, 2016 at 06:48:22AM +0100, Francois Gouget wrote: > > Signed-off-by: Francois Gouget <fgouget@xxxxxxxxxxxxxxx> > > --- > > server/red-qxl.c | 2 ++ > > server/red-replay-qxl.c | 10 ++++++++++ > > server/reds-stream.c | 2 ++ > > server/spice-core.h | 4 ---- > > 4 files changed, 14 insertions(+), 4 deletions(-) > > > > diff --git a/server/spice-core.h b/server/spice-core.h > > index 4d8f2ed..dfd24ab 100644 > > --- a/server/spice-core.h > > +++ b/server/spice-core.h > > @@ -28,10 +28,6 @@ > > #include <spice/vd_agent.h> > > #include <spice/macros.h> > > > > -#ifdef SPICE_SERVER_INTERNAL > > -#undef SPICE_GNUC_DEPRECATED > > -#define SPICE_GNUC_DEPRECATED > > -#endif > > > > /* interface base type */ > > > > This hunk you remove is there so that we ignore internal deprecations, > imo it's ok to have, I'll assume we are not going to add usage of > deprecated functions ourselves. As usual, a slightly longer rationale in > the commit log would be better than just a shortlog. Right. I think I used that argument to not really submit this patch before but somehow I forgot about it. Also your other concern about RHEL 6.8 is right, it does not support G_GNUC_BEGIN_IGNORE_DEPRECATIONS leading to a compilation error. So this patch should be ignored. -- Francois Gouget <fgouget@xxxxxxxxxxxxxxx> _______________________________________________ Spice-devel mailing list Spice-devel@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/spice-devel