On Wed, Nov 23, 2016 at 05:09:05AM -0500, Frediano Ziglio wrote: > > > > On Wed, Nov 23, 2016 at 06:48:22AM +0100, Francois Gouget wrote: > > > Signed-off-by: Francois Gouget <fgouget@xxxxxxxxxxxxxxx> > > > --- > > > server/red-qxl.c | 2 ++ > > > server/red-replay-qxl.c | 10 ++++++++++ > > > server/reds-stream.c | 2 ++ > > > server/spice-core.h | 4 ---- > > > 4 files changed, 14 insertions(+), 4 deletions(-) > > > > > > diff --git a/server/spice-core.h b/server/spice-core.h > > > index 4d8f2ed..dfd24ab 100644 > > > --- a/server/spice-core.h > > > +++ b/server/spice-core.h > > > @@ -28,10 +28,6 @@ > > > #include <spice/vd_agent.h> > > > #include <spice/macros.h> > > > > > > -#ifdef SPICE_SERVER_INTERNAL > > > -#undef SPICE_GNUC_DEPRECATED > > > -#define SPICE_GNUC_DEPRECATED > > > -#endif > > > > > > /* interface base type */ > > > > > > > This hunk you remove is there so that we ignore internal deprecations, > > imo it's ok to have, I'll assume we are not going to add usage of > > deprecated functions ourselves. As usual, a slightly longer rationale in > > the commit log would be better than just a shortlog. > > > > Christophe > > I thinks this is the key of the patch. Instead of disabling all deprecation > disable the warning for specified piece of code. In this case, the situation is very different from the spice-gtk patches. Here we are selectively silencing use of spice-server deprecated functions within spice-server, for spice-gtk we are doing it for our use of deprecated glib functions. Dunno if we want to do that in spice-server. Christophe
Attachment:
signature.asc
Description: PGP signature
_______________________________________________ Spice-devel mailing list Spice-devel@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/spice-devel