On Fri, Oct 28, 2016 at 11:59:56AM +0100, Frediano Ziglio wrote: > This was introduced with 96e94c6f32d4345ea25ef7a474fbd92de03b38ad > (Convert RedChannel hierarchy to GObject). > The id of CursorChannel/DisplayChannel were always 0 causing > a wrong assertion on the code. > > Signed-off-by: Frediano Ziglio <fziglio@xxxxxxxxxx> > --- > server/cursor-channel.c | 1 + > server/display-channel.c | 1 + > 2 files changed, 2 insertions(+) > > diff --git a/server/cursor-channel.c b/server/cursor-channel.c > index df3561a..8887691 100644 > --- a/server/cursor-channel.c > +++ b/server/cursor-channel.c > @@ -312,6 +312,7 @@ CursorChannel* cursor_channel_new(RedsState *server, QXLInstance *qxl, > "spice-server", server, > "core-interface", core, > "channel-type", SPICE_CHANNEL_CURSOR, > + "id", qxl->id, > "migration-flags", 0, > "qxl", qxl, > "handle-acks", TRUE, > diff --git a/server/display-channel.c b/server/display-channel.c > index 63f9986..b483b57 100644 > --- a/server/display-channel.c > +++ b/server/display-channel.c > @@ -1988,6 +1988,7 @@ DisplayChannel* display_channel_new(RedsState *reds, > "spice-server", reds, > "core-interface", core, > "channel-type", SPICE_CHANNEL_DISPLAY, > + "id", qxl->id, > "migration-flags", > (SPICE_MIGRATE_NEED_FLUSH | SPICE_MIGRATE_NEED_DATA_TRANSFER), > "qxl", qxl, Setting "id" to qxl->id in CommonGraphicsChannel when the qxl property is set would be better, but I'm not sure how we would do that with these construct only properties in 2 different classes :( So Acked-by: Christophe Fergeau <cfergeau@xxxxxxxxxx> Christophe
Attachment:
signature.asc
Description: PGP signature
_______________________________________________ Spice-devel mailing list Spice-devel@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/spice-devel