Re: [PATCH spice-server] Remove g_smartcard_channel global

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



> 
> On Thu, Oct 27, 2016 at 05:21:03AM -0400, Frediano Ziglio wrote:
> > > 
> > > I think I would have just switched this to a static variable, possibly a
> > > GOnce if you are worried about thread-safety.
> > > 
> > > Acked-by: Christophe Fergeau <cfergeau@xxxxxxxxxx>
> > > 
> > > Christophe
> > > 
> > 
> > This won't solve having 2 spice server instances on the same executable.
> 
> If this is why you are doing this, this belongs in the commit log, and
> would avoid having a sad one line shortlog in that patch ;)
> 
> Christophe
> 

Sorry... already merged.
Well... removing global and put into a structure does not make much sense
if this structure is a singleton... it just slows down performance and
add additional dependencies...

Frediano
_______________________________________________
Spice-devel mailing list
Spice-devel@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/spice-devel




[Index of Archives]     [Linux ARM Kernel]     [Linux ARM]     [Linux Omap]     [Fedora ARM]     [IETF Annouce]     [Security]     [Bugtraq]     [Linux]     [Linux OMAP]     [Linux MIPS]     [ECOS]     [Asterisk Internet PBX]     [Linux API]     [Monitors]