Re: [PATCH spice-server] Fix handle-acks regression

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Good catch! Wondering if this could be done in
common_graphics_channel_init() maybe, but probably more explicit the way
you did it.

Christophe

On Wed, Oct 26, 2016 at 08:46:41AM +0100, Frediano Ziglio wrote:
> This was introduced with 96e94c6f32d4345ea25ef7a474fbd92de03b38ad
> (Convert RedChannel hierarchy to GObject).
> The handle-acks settings was TRUE for CursorChannel and DisplayChannel.
> 
> Signed-off-by: Frediano Ziglio <fziglio@xxxxxxxxxx>
> ---
>  server/cursor-channel.c  | 1 +
>  server/display-channel.c | 1 +
>  2 files changed, 2 insertions(+)
> 
> I discover this rebasing some other patches that actually
> were attempting to set this flag to FALSE.
> But I think that the change should not be done as a
> regression in another patch.
> 
> diff --git a/server/cursor-channel.c b/server/cursor-channel.c
> index dbe3dfc..df3561a 100644
> --- a/server/cursor-channel.c
> +++ b/server/cursor-channel.c
> @@ -314,6 +314,7 @@ CursorChannel* cursor_channel_new(RedsState *server, QXLInstance *qxl,
>                          "channel-type", SPICE_CHANNEL_CURSOR,
>                          "migration-flags", 0,
>                          "qxl", qxl,
> +                        "handle-acks", TRUE,
>                          NULL);
>  }
>  
> diff --git a/server/display-channel.c b/server/display-channel.c
> index bcf26bb..63f9986 100644
> --- a/server/display-channel.c
> +++ b/server/display-channel.c
> @@ -1993,6 +1993,7 @@ DisplayChannel* display_channel_new(RedsState *reds,
>                             "qxl", qxl,
>                             "n-surfaces", n_surfaces,
>                             "video-codecs", video_codecs,
> +                           "handle-acks", TRUE,
>                             NULL);
>      if (display) {
>          display_channel_set_stream_video(display, stream_video);
> -- 
> 2.7.4
> 
> _______________________________________________
> Spice-devel mailing list
> Spice-devel@xxxxxxxxxxxxxxxxxxxxx
> https://lists.freedesktop.org/mailman/listinfo/spice-devel

Attachment: signature.asc
Description: PGP signature

_______________________________________________
Spice-devel mailing list
Spice-devel@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/spice-devel

[Index of Archives]     [Linux ARM Kernel]     [Linux ARM]     [Linux Omap]     [Fedora ARM]     [IETF Annouce]     [Security]     [Bugtraq]     [Linux]     [Linux OMAP]     [Linux MIPS]     [ECOS]     [Asterisk Internet PBX]     [Linux API]     [Monitors]