Re: [PATCH spice-server 02/12] Be consistent with opaque type

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



> 
> On Wed, Oct 26, 2016 at 02:43:22AM -0400, Frediano Ziglio wrote:
> > I think that my reasoning is more focuses on the "get refcounting for free"
> > not being
> > a great design so willing to change and I prefer a compile error in the
> > future
> > instead on the "base type".
> 
> Well, this makes the intent of the code harder to get imo, this falls
> apart as soon as an intermediate class is added, ... so I really don't
> think explicit mentions of the 'base' field in the code is something we
> should encourage. If wrapped in a macro, why not, but this still leaves
> the problem that this only work with one level of inheritance.
> 
> Christophe
> 

I prefer having to change the source instead of spending hours
digging into core files. If base is removed no warnings are issues
and memory corruptions happens.

Frediano
_______________________________________________
Spice-devel mailing list
Spice-devel@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/spice-devel




[Index of Archives]     [Linux ARM Kernel]     [Linux ARM]     [Linux Omap]     [Fedora ARM]     [IETF Annouce]     [Security]     [Bugtraq]     [Linux]     [Linux OMAP]     [Linux MIPS]     [ECOS]     [Asterisk Internet PBX]     [Linux API]     [Monitors]