OK. Perhaps a bit more explicit description would be useful, since I was also slightly confused. something like: Allow both compiled and non-compiled tests to be used with "make check". Compiled tests should be added to check_PROGRAMS, and scripts that do not need to be built should be added to TESTS. Acked-by: Jonathon Jongsma <jjongsma@xxxxxxxxxx> On Wed, 2016-10-19 at 10:13 -0400, Frediano Ziglio wrote: > > > > > > Sorry, what do you mean ? > > > > Currently all the executable that compose the test list > must be compiled. > > This as check_PROGRAMS == TESTS. > > If you have > > TESTS = test1 test2 > check_PROGRAMS = test1 > > "make check" will compile test1 and run test1 and test2 as > tests. But if you add test2 to check_PROGRAMS make check > will try to compile test2 failing if not possible (for > instance cause test2 it's just a bash script) > > Frediano > > > > > On Wed, 2016-10-19 at 14:49 +0100, Frediano Ziglio wrote: > > > > > > Signed-off-by: Frediano Ziglio <fziglio@xxxxxxxxxx> > > > --- > > > server/tests/Makefile.am | 7 ++++--- > > > 1 file changed, 4 insertions(+), 3 deletions(-) > > > > > > diff --git a/server/tests/Makefile.am b/server/tests/Makefile.am > > > index 17a06e8..8580a9a 100644 > > > --- a/server/tests/Makefile.am > > > +++ b/server/tests/Makefile.am > > > @@ -36,7 +36,7 @@ LDADD = > > > \ > > > $(SPICE_NONPKGCONFIG_LIBS) > > > \ > > > $(NULL) > > > > > > -TESTS = \ > > > +check_PROGRAMS = \ > > > spice-options-test \ > > > stat_test \ > > > stream-test \ > > > @@ -57,10 +57,11 @@ noinst_PROGRAMS = > > > \ > > > test_vdagent \ > > > test_display_width_stride \ > > > spice-server-replay \ > > > - $(TESTS) \ > > > + $(check_PROGRAMS) \ > > > $(NULL) > > > > > > -check_PROGRAMS = $(TESTS) > > > +TESTS = $(check_PROGRAMS) \ > > > + $(NULL) > > > > > > noinst_LIBRARIES += \ > > > libstat_test1.a \ > > > _______________________________________________ > Spice-devel mailing list > Spice-devel@xxxxxxxxxxxxxxxxxxxxx > https://lists.freedesktop.org/mailman/listinfo/spice-devel _______________________________________________ Spice-devel mailing list Spice-devel@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/spice-devel