On Wed, 19 Oct 2016, Victor Toso wrote: [...] > > This one may be somewhat questionable since it spice-protocol's macros > > don't use GLib's helpers and thus don't support Clang and Visual C++. > > This means we may locally disable these warnings with > > G_GNUC_BEGIN_IGNORE_DEPRECATIONS when they would not have in fact been > > issued at all. > > * It's not like this issue would cause compilation errors or > > warnings (the opposite) so maybe it should just be ignored. > > * Or maybe it means Spice-Gtk should keep using its own deprecation > > macros, but it would be a bit of a shame that spice-protocol's macros > > cannot even be reused by all Spice's codebase. > > * Or maybe spice-protocol should use GLib's macros if available, > > even if it is a bit distasteful. > > I recall that Christophe commented about the spice macros but I failed > to find it. It's likely this one: https://lists.freedesktop.org/archives/spice-devel/2016-September/031603.html > > session: Disable the spice_audio_new() deprecation warning > > > > I donsider this to be a "false positive", although maybe the code should > > be rewritten to avoid it. > > Yes, I think we can remove for public header nowadays (i replied earlier > to that one) Ok. I'll give it a try. > > RFC: gtk: Temporarily ignore the keyboard/mouse grabbing deprecation warnings > > RFC: spicy: Temporarily ignore deprecation warnings > > > > These two really just silence warnings that should be fixed. So if > > someone fixes these warnings they will not be needed. Otherwise I think > > it's still better than globally disabling the deprecation warnings > > because these patches are local and add nice FIXME warnings in the > > relevant places. > > I think we should try to fix this two and not ignore the warnings. We > are early in 0.33. Well, if someone wants to volunteer... -- Francois Gouget <fgouget@xxxxxxxxxxxxxxx> _______________________________________________ Spice-devel mailing list Spice-devel@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/spice-devel