Re: [PATCH 03/18] Add small comment for detach_stream

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, Sep 26, 2016 at 09:12:36AM +0100, Frediano Ziglio wrote:
> Signed-off-by: Frediano Ziglio <fziglio@xxxxxxxxxx>
> ---
>  server/stream.c | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/server/stream.c b/server/stream.c
> index 9d878c8..95ff015 100644
> --- a/server/stream.c
> +++ b/server/stream.c
> @@ -320,6 +320,9 @@ static void attach_stream(DisplayChannel *display, Drawable *drawable, Stream *s
>      }
>  }
>  
> +/**
> + * Detach drawable from the stream.
> + */
>  void detach_stream(DisplayChannel *display, Stream *stream)

This does not make what the function does a lot more explicit to me ;)
Wouldn't it be better to rename the function instead?
detach_drawable_from_stream() still seems (nearly) acceptable from a
length point of view?

Christophe

Attachment: signature.asc
Description: PGP signature

_______________________________________________
Spice-devel mailing list
Spice-devel@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/spice-devel

[Index of Archives]     [Linux ARM Kernel]     [Linux ARM]     [Linux Omap]     [Fedora ARM]     [IETF Annouce]     [Security]     [Bugtraq]     [Linux]     [Linux OMAP]     [Linux MIPS]     [ECOS]     [Asterisk Internet PBX]     [Linux API]     [Monitors]