On Tue, Sep 27, 2016 at 06:01:28AM -0400, Frediano Ziglio wrote: > > > > Isn't this already tested somewhere else before reaching this place? Not > > really opposed to the patch, but knowing how this can be hit would > > probably be useful. > > > > Christophe > > > > Currently this is simply avoided by the fact that Virgl with 3d means > Unix socket. Once you enable (in Qemu) tcp sockets this message will > be added to all clients (supposing multiple clients) so potentially > will be in all queues. The same check is done for dcc_gl_scanout_item_new. > dcc_gl_scanout_item_new is called when Qemu calls spice_qxl_gl_draw_async. > Technically a client can support SPICE_DISPLAY_CAP_GL_SCANOUT but server > cannot send the DRM prime directly as this require a unix socket so > if the test for SPICE_DISPLAY_CAP_GL_SCANOUT is done here it make sense > to do the check for the socket type too. > > I could probably c&p the entire paragraph above in the commit message. Exactly what I was thinking :) Thanks for the explanation! Acked-by: Christophe Fergeau <cfergeau@xxxxxxxxxx> Christophe
Attachment:
signature.asc
Description: PGP signature
_______________________________________________ Spice-devel mailing list Spice-devel@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/spice-devel