Re: [PATCH] Fixed error when trying to access undefined source buffer without checking it first

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



AFAIK My setup is very basic. I'm using a gnome-boxes machine, and modifying the xml for libvirt machine to setup a spice graphics adapter with autoport enabled.

Then I run websockify and connect with spice-html5 client. Nothing strange.

If you want to look to implementation I do for setting up the client you can see it at https://github.com/fleet-commander/fc-admin/blob/master/admin/cockpit/fleet-commander-admin/js/fcspiceclient.js

There is a workaround I did to spice code to avoid client send alerts and start debugger in file: https://github.com/fleet-commander/fc-admin/blob/master/admin/cockpit/fleet-commander-admin/js/spice_debug_bypass.js

This are the only modifications I've done

On Thu, Jul 28, 2016 at 2:00 PM, Christophe Fergeau <cfergeau@xxxxxxxxxx> wrote:
On Thu, Jul 28, 2016 at 12:59:05PM +0100, Oliver Gutierrez wrote:
> The problem I was having was the spice-html5 client was throwing exceptions
> for trying to access that property in cases where it is not a valid value.
>
> I got to the error because I'm developing a plugin for cockpit that makes
> use of spice-html5 for connecting to VMs, and when spice-html5 starts
> displaying graphics, it throws this error repeatedly, causing cockpit to
> show an awfull "Oops" message.
>
> It just failed throwing exceptions to console. It stopped the playback when
> failed, so with the change it stops anyway but without throwing errors.
>
> I hope this answer your questions. My knowledge about spice-html5 or spice
> is limited, so I don't know if this info is enough for you.

Any idea what is different in your setup compared to 'traditional'
setups? I expect this bug is not always happening or it would have been
noticed earlier?

Christophe



--
Oliver Gutierrez
Associate Software Engineer - Desktop Management tools
Red Hat
_______________________________________________
Spice-devel mailing list
Spice-devel@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/spice-devel

[Index of Archives]     [Linux ARM Kernel]     [Linux ARM]     [Linux Omap]     [Fedora ARM]     [IETF Annouce]     [Security]     [Bugtraq]     [Linux]     [Linux OMAP]     [Linux MIPS]     [ECOS]     [Asterisk Internet PBX]     [Linux API]     [Monitors]