Hey,
Thanks for the patch!
I'd expand a bit in the commit log, that this.source_buffer can be used
before being checked for null, and that this commit moves the check
before the first use of this.source_buffer.
You could also describe what happens when this triggers/how this
triggers (I assume playback stops?)
On Thu, Jul 28, 2016 at 10:50:05AM +0100, Oliver Gutierrez wrote:
> ---
> playback.js | 9 ++++-----
> 1 file changed, 4 insertions(+), 5 deletions(-)
>
> diff --git a/playback.js b/playback.js
> index 9659381..b5954da 100644
> --- a/playback.js
> +++ b/playback.js
> @@ -107,21 +107,20 @@ SpicePlaybackConn.prototype.process_channel_message = function(msg)
> So we do two things. First, we seek forward. Second, we compute how much of a gap
> there would have been, and essentially eliminate it.
> */
> + if (! this.source_buffer)
> + return true;
> +
> if (this.last_data_time && data.time >= (this.last_data_time + GAP_DETECTION_THRESHOLD))
> {
> this.skip_until = data.time;
> - this.gap_time = (data.time - this.start_time) -
> + this.gap_time = (data.time - this.start_time) -
This looks like an unrelated whitespace change
Looks good otherwise!
Reviewed-by: Christophe Fergeau <cfergeau@xxxxxxxxxx>
Christophe
Attachment:
signature.asc
Description: PGP signature
_______________________________________________ Spice-devel mailing list Spice-devel@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/spice-devel