Re: [PATCH 7/7] Limit direct access to DisplayChannelClient

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Sun, 2016-05-22 at 04:19 -0400, Frediano Ziglio wrote:

> >  /* FIXME: move back to display-channel.h (once structs are private) */
> >  typedef struct Drawable Drawable;
> > -typedef struct DisplayChannelClient DisplayChannelClient;
> >  
> 
> We definitively should consider using struct Xxxx instead of moving
> these typedef everytime in order to compile...

Or create a spice-types.h header that contains forward declarations for all
structs and include that in every other file. The includes really are quite a
tangled mess and it's not an easy problem to unravel. I spent some time trying,
but it's very difficult to do in a gradual way. I've resisted doing something
like this in the past, but I'm starting to warm up to it...

Jonathon
_______________________________________________
Spice-devel mailing list
Spice-devel@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/spice-devel




[Index of Archives]     [Linux ARM Kernel]     [Linux ARM]     [Linux Omap]     [Fedora ARM]     [IETF Annouce]     [Security]     [Bugtraq]     [Linux]     [Linux OMAP]     [Linux MIPS]     [ECOS]     [Asterisk Internet PBX]     [Linux API]     [Monitors]